Improve property parsing (Proto-typed with the string value) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty objects in PropertyCollection before it is added as the objectValue, tests have also been added
andrewtarry
suggested changes
Mar 11, 2020
| return stringValue; | ||
| } | ||
|
|
||
| private boolean checkObjectValueIsAPropertyCollection(Optional<Property> property) { |
There was a problem hiding this comment.
Do you need to pass in an optional here? Would it make more sense to test if the optional is present in the loop and break if its not so you only need to pass in property here?
| return true; | ||
| } | ||
|
|
||
| private boolean checkPropertyValueIsAString(Optional<Property> property) { |
|
|
||
| private boolean checkPropertyValueIsAString(Optional<Property> property) { | ||
| if(property.isEmpty()) return false; | ||
| if(!property.get().hasStringValue()) return false; |
There was a problem hiding this comment.
you could just do return property.get().hasStringValue();
|
|
||
| // Checks if the objectValue is a PropertyCollection | ||
| Optional<PropertyCollection> propertyCollection = property.get().getObjectValue(PropertyCollection.class); | ||
| if(propertyCollection.isEmpty()) return false; |
There was a problem hiding this comment.
return propertyCollection.isPresent();
| Optional<Property> subProperty = Optional.empty(); | ||
| Optional<String> stringValue = Optional.of(""); | ||
|
|
||
| String [] pathArray = path.split("\\."); |
There was a problem hiding this comment.
It would be worth checking if path is null before this, just in case
|
|
||
| import java.util.Optional; | ||
|
|
||
| public class PropertyMapper { |
There was a problem hiding this comment.
Can you add a java doc to explain what this does, how to use it and with your names as the @author
|
@BrandonAGoodwin Looks really good. I've added a few minor comments but nice work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property mapper has been set up to work for the getStringValue method, but can be further refactored so that extending to include other get value methods is made easy.
This also includes the new Property setter and PropertyCollection wrapper.