Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positioning of popover #70

Open
Grotlo opened this issue Feb 18, 2020 · 2 comments
Open

Positioning of popover #70

Grotlo opened this issue Feb 18, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@Grotlo
Copy link

Grotlo commented Feb 18, 2020

The presentation and look of the calendar is pretty slick, but there should be an option to position the calendar based on the button. Like above or below from the button, or left or right. When I used my version of the calendar, I wanted it below and right-aligned with the button, so I changed the percentage value of the contents-wrapper, like so:

bilde

It works, but it should rather be a prop. We use the calendar multiple times and each of them isn't meant to be in this position. If this would become an enchancement, the button should also close the calendar.

@6eDesign 6eDesign added the enhancement New feature or request label Feb 28, 2020
@6eDesign
Copy link
Owner

That's an interesting idea. The way the popover component works right now is intentional but this might be a nice enhancement (I've labeled it as such). I'm not sure it's as simple as allowing that position to be set as a prop, though, as the component does do some viewport boundary detection to make sure it does not position itself partially/completely out of the viewport. It's also worth noting that the popover positions differently on mobile (to be closer to the user's thumbs). I'm not sure how this would interact with any sort of positioning prop/option.

@Grotlo Grotlo mentioned this issue Mar 4, 2020
@antony
Copy link
Contributor

antony commented Aug 14, 2020

Just wanted to say that we also need a feature like this, since we are now embedding iframes in client pages, and the viewport is the whole iframe, not the browser.

Would be great to be able to configure this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants