Skip to content

[cob_sick_s300] Timestamp calculation is not implemented #293

Open
@mingless

Description

@mingless

In ScannerSickS300.cpp getScan() function always returns iTimeNow=0;
and does not assign value to iTimestamp. This is used by cob_sick_s300.cpp in publishLaserScan() to calculate the message timestamp.

            // Sync handling: find out exact scan time by using the syncTime-syncStamp pair:
            // Timestamp: "This counter is internally incremented at each scan, i.e. every 40 ms (S300)"
            if(iSickNow != 0) {
                syncedROSTime = ros::Time::now() - ros::Duration(scan_cycle_time);
                syncedSICKStamp = iSickNow;
                syncedTimeReady = true;

                ROS_DEBUG("Got iSickNow, store sync-stamp: %d", syncedSICKStamp);
            } else syncedTimeReady = false;

Since it's not implemented it only obfuscates the code while always ending up with ros::Time::now().

Will the timestamp calculation be implemented?

@fmessmer FYI

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions