Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cob_sick_s300] Timestamp calculation is not implemented #293

Open
mingless opened this issue Sep 4, 2016 · 3 comments
Open

[cob_sick_s300] Timestamp calculation is not implemented #293

mingless opened this issue Sep 4, 2016 · 3 comments

Comments

@mingless
Copy link

mingless commented Sep 4, 2016

In ScannerSickS300.cpp getScan() function always returns iTimeNow=0;
and does not assign value to iTimestamp. This is used by cob_sick_s300.cpp in publishLaserScan() to calculate the message timestamp.

            // Sync handling: find out exact scan time by using the syncTime-syncStamp pair:
            // Timestamp: "This counter is internally incremented at each scan, i.e. every 40 ms (S300)"
            if(iSickNow != 0) {
                syncedROSTime = ros::Time::now() - ros::Duration(scan_cycle_time);
                syncedSICKStamp = iSickNow;
                syncedTimeReady = true;

                ROS_DEBUG("Got iSickNow, store sync-stamp: %d", syncedSICKStamp);
            } else syncedTimeReady = false;

Since it's not implemented it only obfuscates the code while always ending up with ros::Time::now().

Will the timestamp calculation be implemented?

@fmessmer FYI

@floweisshardt
Copy link
Contributor

@ipa-josh: can you please comment on this?

@mingless
Copy link
Author

mingless commented Nov 9, 2016

Since I am not currently using any Sick scanners it's not a pressing issue for me, but if needed I am available and will gladly contribute.

@mgruhler
Copy link
Contributor

@mingless thank you for the offer. If you find the time, we are happy to accept any contributions.

Otherwise, we ahve it on our list and will hopefully find the time soon to implement this. @ipa-josh

@fmessmer fmessmer changed the title Timestamp calculation is not implemented [cob_sick_s300] Timestamp calculation is not implemented Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants