Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JsNumber and JsDecimal models #71

Open
AdrianRaFo opened this issue May 24, 2019 · 3 comments
Open

Improve JsNumber and JsDecimal models #71

AdrianRaFo opened this issue May 24, 2019 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@AdrianRaFo
Copy link
Contributor

AdrianRaFo commented May 24, 2019 •
edited
Loading

Currently JsDecimal is just only used for BigInteger and BigDecimal and all the other types Int, Long ... extends from the Number interface.
If we use JsNumber for the Number interface we can reduce a lot of boilerplate without losing compatibility between them.
@AdrianRaFo AdrianRaFo added enhancement New feature or request question Further information is requested labels May 24, 2019
@AdrianRaFo
Copy link
Contributor Author

@nomisRev @raulraja thoughts?

@AdrianRaFo AdrianRaFo changed the title Separate JsNumber and JsDecimal Improve JsNumber and JsDecimal models May 30, 2019
@AdrianRaFo AdrianRaFo mentioned this issue May 30, 2019
Merged
@AdrianRaFo
Copy link
Contributor Author

AdrianRaFo commented May 30, 2019 •
edited
Loading

Related to #69 (comment)
We can also move all the Js numeric models to internal models because we already have a public API on JsNumber which maps each numeric type to its own proper js model

@nomisRev
Copy link
Contributor

nomisRev commented Oct 3, 2019 •
edited
Loading

all the Js numeric models to internal models

That is actually what Circe does, and it also drastically simplifies #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nomisRev @AdrianRaFo