Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this a dead comment? #130

Open
jnorthrup opened this issue Oct 26, 2019 · 2 comments
Open

is this a dead comment? #130

jnorthrup opened this issue Oct 26, 2019 · 2 comments

Comments

@jnorthrup
Copy link

@jnorthrup
Copy link
Author

I'm taking a look at Arrow-kt and one of my goto's is to find a json parser done in such and such style.

as i try to sift the Arrow from the kotlin, i notice the comment looks a touch out of sync.. i am curious what prompted the refactoring. any performance numbers to share of when vs if pros/cons ? it certainly would be more readable as when{}

@raulraja
Copy link
Contributor

Last time we checked it was faster due to the optimization to a table switch but feel free to add a benchmark over an alternative implementation and we will use whichever is fastest, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants