Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML01 ex05 (z_score): incoherent example #237

Open
2 tasks
mli42 opened this issue Aug 24, 2022 · 0 comments
Open
2 tasks

ML01 ex05 (z_score): incoherent example #237

mli42 opened this issue Aug 24, 2022 · 0 comments
Labels

Comments

@mli42
Copy link

mli42 commented Aug 24, 2022

  • Day: 06
  • Exercise: 05

There are 3 minors issues:

Turn in filename

The subject header says: Files to turn in : z_score.py

But the instructions says: In the zscore.py file, write the zscore function (without the underscore)

Undefined numpy

In the examples, X is defined while calling numpy, but Y is defined while calling np

Mismatching Y shape

Still in the examples, Y is declared as follows:
Y = np.array([2, 14, -13, 5, 12, 4, -19]).reshape((-1, 1))
Thus its shape is (2, 1) and not (2, ) as X.

The problem is that the expected value is:
array([ 0.11267619, 1.16432067, -1.20187941, 0.37558731, 0.98904659, 0.28795027, -1.72770165]) which shape is (7, ), IMO it should be (7, 1) so the zscore function can copy the incomming array's shape.

Fixed on:

  • Github
  • Gitlab
@mli42 mli42 added the fixme label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant