Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KtTable): fix styling issues with the table #1034

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

Isokaeder
Copy link
Collaborator

@Isokaeder Isokaeder commented Dec 15, 2024

  • slide in sorting indicator if header is right-aligned
  • add spacing to header to make it properly center-aligned if sorting indicator is present
  • show inline loading state if rows are present
  • put custom styles into td/th elements to support relative widths

@github-actions github-actions bot added package:kotti-ui @3yourmind/kotti-ui scope:documentation Affects the documentation labels Dec 15, 2024
@Isokaeder Isokaeder force-pushed the minor-fixes-for-table branch from 6699e41 to bf317bf Compare December 15, 2024 02:09
@Isokaeder
Copy link
Collaborator Author

  • (optional) selected rows should have blue background
  • action icons need bigger click area
  • put indicator on the left if column is right aligned
  • double indicator on hover if sortable but unsorted header is hovered

@Isokaeder Isokaeder force-pushed the minor-fixes-for-table branch 2 times, most recently from 9265a13 to 2a7c0a0 Compare December 19, 2024 01:44
@github-actions github-actions bot added the package:yoco @3yourmind/yoco label Dec 19, 2024
@Isokaeder Isokaeder force-pushed the minor-fixes-for-table branch from 2a7c0a0 to 9382789 Compare December 20, 2024 13:31
@Isokaeder Isokaeder force-pushed the minor-fixes-for-table branch 2 times, most recently from 2d3ea1d to d7821b1 Compare December 28, 2024 22:15
Copy link
Member

@FlorianWendelborn FlorianWendelborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Isokaeder Isokaeder force-pushed the minor-fixes-for-table branch from d7821b1 to a41b24f Compare December 28, 2024 22:36
@Isokaeder Isokaeder enabled auto-merge December 28, 2024 22:37
- add spacing to header to make it properly center-aligned if sorting indicator is present
- show inline loading state if rows are present
- mark selected rows
- improve layout of row actions
@Isokaeder Isokaeder force-pushed the minor-fixes-for-table branch from a41b24f to 0aa171c Compare December 29, 2024 02:04
@Isokaeder Isokaeder merged commit 50e849c into master Dec 29, 2024
9 checks passed
@Isokaeder Isokaeder deleted the minor-fixes-for-table branch December 29, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:kotti-ui @3yourmind/kotti-ui package:yoco @3yourmind/yoco scope:documentation Affects the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants