Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling o multiple slicestacks in a components-hierarchy is not clear #8

Open
martinweismann opened this issue Sep 13, 2018 · 3 comments
Assignees

Comments

@martinweismann
Copy link
Member

The slicespec allows to define slicestacks on any object, as per https://github.com/3MFConsortium/spec_slice/blob/master/3MF%20Slice%20Extension.md#object

Thus, you can refer to a slicestack from a componetsobject A and from a different object B, which is referenced from this componentsobject.

Problem: it is not clearly specified, which slicestack-representation takes precedence, how/if they are merged, or in general, how this situation is handled.

Example:
image

problematic.txt

@martinweismann martinweismann assigned ghost Nov 28, 2018
@jordig100 jordig100 assigned jordig100 and unassigned ghost Jan 18, 2019
@jordig100
Copy link
Contributor

jordig100 commented Jan 18, 2019

The way that HP has implemented it is by acknowledging the hierarchy. If a Components object has defined a slicestack it would take it as the representation of the components, and discarding the individual representation of each component.

I propose to consolidate this behaviour by documenting it.

Let's propose a test case to cover it.

@jordig100
Copy link
Contributor

Added the following paragraph to the spec under Object:

The slicestack MIGHT be defined into components object providing a slicestack for the combined components or into an individual mesh object. When the slicestack is defined in both types of objects, the slicestack that prevails MUST be the one at the components level.

@JimZuber
Copy link

New test case added the will demonstrate if the printer select the right precedence between a slicestack defined at the object or component level.

@JimZuber JimZuber reopened this Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants