-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise support #7
Comments
That would be really useful. Let's await @makinde's merge and then we can review that PR. How would you like to add the polyfill? We could add Typescript. |
Awesome! Would be cool to add typescript, it would clean up the code a bunch. |
@xChrisPx I forget if I got you setup to push to npm as well. If not just let me know and Im happy to help so you can get v2 out. |
Nice, that would be cool, and I might need that as well :) There are a couple decisions to make here:
[edit] removed my comment about typescript. |
Let me amend what I said, just peeked at the docs. It looks like typescript is mainly at the function interfaces. So it doesn't look too hard to follow the lead of others here. I'm slightly less skeptical :P |
I have used typescript and babel, I don't get too crazy with the types so I don't have a strong opinion either way. |
Sorry for being late to the discussion: We use Typescript exclusively on the server side and it is a great advantage. We don't have to go to crazy with the types either. I will create a PR right away. The good thing is that we don't need to add types, if we don't want to, but we also get all the nice polyfills. |
If anyone is interested in taking a look, PR #23 adds promise support. |
I converted the newly announced 2.0.0-rc1 branch to support promises in the getAuthLevel function. This is useful for fetching models for authorization. Still needs tests and a promise polyfill (for pre es6 support). I'm just trying to figure out if people are interested.
The text was updated successfully, but these errors were encountered: