Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagine of major release #32

Open
2nthony opened this issue Mar 8, 2022 · 1 comment
Open

Imagine of major release #32

2nthony opened this issue Mar 8, 2022 · 1 comment

Comments

@2nthony
Copy link
Owner

2nthony commented Mar 8, 2022

template(starter) = theme

the theme and template(starter) should be together, which means is a theme is a template(starter).

Therefore, the template will become a basic next.js project. I am very clear that the theme should be separate from blogkit config file.

The starter should use yarn, the main reason is Vercel uses yarn. Install pnpm is fine.

reduce threshold

use js in template, not ts. (core sure ts)

breaking

remove theme field in blogkit.config.js, reason see above.

getHomePageStaticProps -> getPostListStaticProps
getPostPageStaticProps -> getPostStaticProps


setting the theme in config file makes extending pages or features hard.

@2nthony
Copy link
Owner Author

2nthony commented Jan 23, 2023

change then request to adapter in blogkit.config.js

also the packages change to blogkit-adapter-*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant