Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] [60min *max*] Investigate binderhub's image re-building logic #4340

Closed
consideRatio opened this issue Jul 3, 2024 · 1 comment
Closed

Comments

@consideRatio
Copy link
Contributor

We have a bug making us rebuild images already built in binderhub when working against quay.io as reported in #4315. Its hard to say what to do in order to resolve that without doing an investigation and learning a bit about how things work.

  • investigate binderhub's image re-building logic
    • how and where does it decide if should re-build an image?
    • is there authentication steps involved in this logic, and does it accept configuration related to it?
@consideRatio
Copy link
Contributor Author

how and where does it decide if should re-build an image?

Answer: If get_image_manifest returned truthy

is there authentication steps involved in this logic, and does it accept configuration related to it?

Yes. There is DockerRegistry.username DockerRegistry.password config, also DockerRegistry.url and DockerRegistry.token_url. These configuration options also have default values that stem from inspecting a docker config, and its also possible to provide a docker config in order to provide credentials.

Me and @sgibson91 tried to configure this via binderhub-service.config.DockerRegistry in the opensci small binder chart, but didn't get it functional all the way. We probably need to declare url to the registry as well.

Another alternative approach is to provide the binderhub pod a docker config with credentials, just like we do for the builder pods. There isn't any extraVolumes and extraVolumeMounts currently, so this would have to be done by a change in binderhub-service one way or another no matter what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant