Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Transperth #8179

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Add Transperth #8179

merged 1 commit into from
Aug 31, 2024

Conversation

hkamran80
Copy link
Member

Resolves #8161

@hkamran80 hkamran80 added the add site Issue/PR adds a site to the repo. label Aug 31, 2024
@hkamran80
Copy link
Member Author

hkamran80 commented Aug 31, 2024 •
edited
Loading

Similarweb seems to be tracking subdomains now (or it's because wa.gov.au is in the Public Suffix List) because transperth.wa.gov.au has a global rank of 71,369.

@hkamran80 hkamran80 mentioned this pull request Aug 31, 2024
Merged
Carlgo11
Carlgo11 approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@Carlgo11 Carlgo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always fun when APIs change their functionality without notice. Thanks SimilarWeb!

@Carlgo11 Carlgo11 merged commit 0660ea3 into 2factorauth:master Aug 31, 2024
1 of 2 checks passed
@hkamran80
Copy link
Member Author

I think it's because of the Public Suffix List.

@hkamran80 hkamran80 deleted the add/transperth branch August 31, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carlgo11 Carlgo11 Carlgo11 approved these changes

Assignees
No one assigned
Labels
add site Issue/PR adds a site to the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Transperth
2 participants
@hkamran80 @Carlgo11