fix: set comprehend_client when ComprehendFilterAgent creates a default client#514
Open
YuemengZheng wants to merge 1 commit into
Open
Conversation
When no client was passed, the boto3 client was assigned to self.client instead of self.comprehend_client, so process_request raised AttributeError. Assign it to self.comprehend_client and add a regression test. Closes 2FastLabs#359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link (REQUIRED)
Fixes #359
Summary
Changes
When no
clientis passed toComprehendFilterAgent, the constructor created the boto3 Comprehend client but assigned it toself.clientinstead ofself.comprehend_client. Sincedetect_sentiment/detect_pii_entities/detect_toxic_contentall useself.comprehend_client, callingprocess_requestraised:'ComprehendFilterAgent' object has no attribute 'comprehend_client'.Assign the default-created client to
self.comprehend_clientso the agent works without an explicitly provided client. Added a regression test that patchesboto3.clientand assertscomprehend_clientis set whenclient=None.User experience
Before: constructing a
ComprehendFilterAgentwithout aclient(the documented default) crashed on the first request. After: the agent creates its own Comprehend client and runs normally.Checklist