Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add haptic feedback when seeking between segments #68

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add haptic feedback when seeking between segments #68

wants to merge 6 commits into from

Conversation

abdallahmehiz
Copy link

A similar effect to what Youtube has.

@2307vivek
Copy link
Owner

Good feature. Will merge after some testing.

@2307vivek
Copy link
Owner

HapticFeedbackType.TextHandleMove doesn't work on some devices. Only LongPress works.

@2307vivek
Copy link
Owner

The intended behavior should be that the haptics works only when the user is dragging on the seekbar, but the haptics gets activated even when the segment changes while in progress or when the LaunchedEffect is composed for the first time.

This is due to LaunchedEffect lamda being invoked whenever the segment changes. This should not be happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdallahmehiz @2307vivek