Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C Code Structure #89

Closed
steven-murray opened this issue Feb 6, 2020 · 1 comment
Closed

C Code Structure #89

steven-murray opened this issue Feb 6, 2020 · 1 comment
Assignees
@steven-murray @BradGreig @daviesje
Labels
context: C backend Changes occur predominantly in the C code type: refactor Code refactoring / restyling for internal benefit
Milestone
v3.3.0

Comments

@steven-murray
Copy link
Member

The structure of how the C code uses header files and #includes is kind of strange and almost certainly sub-optimal.

We should look into streamlining this and making it more modular.
@steven-murray steven-murray added help wanted context: C backend Changes occur predominantly in the C code labels Feb 6, 2020
@steven-murray steven-murray added type: refactor Code refactoring / restyling for internal benefit and removed help wanted labels Sep 30, 2020
@steven-murray steven-murray added this to the v3.3.0 milestone Oct 8, 2020
This was referenced Oct 8, 2020
Open
Open
@steven-murray
Copy link
Member Author

Closing since this is superseded by #359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steven-murray steven-murray

@BradGreig BradGreig

@daviesje daviesje

Labels
context: C backend Changes occur predominantly in the C code type: refactor Code refactoring / restyling for internal benefit
Projects
21cmFAST v4
Status: Done
Milestone
v3.3.0
Development

No branches or pull requests
3 participants
@steven-murray @BradGreig @daviesje