Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pyc2ray as an optional IonizedBox compute function #426

Open
daviesje opened this issue Sep 16, 2024 · 0 comments
Open

Integrate pyc2ray as an optional IonizedBox compute function #426

daviesje opened this issue Sep 16, 2024 · 0 comments
Labels
context: python wrapper Predominantly affecting the Python wrapper context: v4-prep This issue regards changes to the v4-prep branch science project Something that we can write a paper on type: feature: physical New physical feature to be included

Comments

@daviesje
Copy link
Contributor

With the new halo sampler, we should be able to create a flag which substitutes the excursion set reionisation algorithms for model comparison tests. Michele Bianco has already done a lot of work in getting the halo-related outputs from 21cmFAST to work with pyc2ray, and we would like to implement this fully within the py21cmfast package. The main steps would be as follows:

  • alter the compute() method of IonizedBox to optionally bypass the regular compute method, calling another function in the wrapper.
  • this function would take a HaloField or HaloBox, convert it to the units expected by pyc2ray, pass the required fields to the GPU if needed, and call the ASORA RT algorithm. It would then populate the IonizedBox fields with those given by pyc2ray.

Calculating from the HaloBox would be much easier as we just need to pass in the n_ion and density fields, but to get a little more resolution on our sources (effectively a grid of DIM rather than HII_DIM) we could pass in the catalogs in HaloField after converting to ionising emissivity using the functions in HaloBox.c.

@daviesje daviesje added context: python wrapper Predominantly affecting the Python wrapper context: v4-prep This issue regards changes to the v4-prep branch science project Something that we can write a paper on type: feature: physical New physical feature to be included labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: python wrapper Predominantly affecting the Python wrapper context: v4-prep This issue regards changes to the v4-prep branch science project Something that we can write a paper on type: feature: physical New physical feature to be included
Projects
Status: No status
Development

No branches or pull requests

1 participant