Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make writing of PerturbHaloField optional #390

Open
daviesje opened this issue May 20, 2024 · 0 comments
Open

Make writing of PerturbHaloField optional #390

daviesje opened this issue May 20, 2024 · 0 comments
Assignees
Labels
context: C backend Changes occur predominantly in the C code context: v4-prep This issue regards changes to the v4-prep branch type: performance: speed Changes affecting speed of calculations

Comments

@daviesje
Copy link
Contributor

Since the HaloField can get quite large, there can be a significant amount of IO which slows down the simulation when caching. However we don't always need to save both HaloField and PerturbHaloField. So this change would have two steps:

  • Move the perturb_halo_field call to the forward time loop, and switch the caching to the HaloField
  • Create a flag which switches on/off the caching of the PerturbHaloField

Since calls to perturb_halo_field are quite quick (possibly faster than the IO), I would imagine that the default should be to not cache it.

@daviesje daviesje added context: C backend Changes occur predominantly in the C code context: v4-prep This issue regards changes to the v4-prep branch type: performance: speed Changes affecting speed of calculations labels May 20, 2024
@daviesje daviesje self-assigned this May 20, 2024
@daviesje daviesje linked a pull request Oct 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: C backend Changes occur predominantly in the C code context: v4-prep This issue regards changes to the v4-prep branch type: performance: speed Changes affecting speed of calculations
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

1 participant