Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Interpolation Table Test Failures #367

Open
daviesje opened this issue Mar 28, 2024 · 0 comments
Open

Fixing Interpolation Table Test Failures #367

daviesje opened this issue Mar 28, 2024 · 0 comments
Assignees
Labels
context: v4-prep This issue regards changes to the v4-prep branch type: testing Adds or modifies tests

Comments

@daviesje
Copy link
Contributor

daviesje commented Mar 28, 2024

There have been a range of added tests in v4-prep, mostly regarding the interpolation tables and mass function integrals. These tables are very accurate in the majority of bins, but there are some bins (usually near critical density or where turnover masses are extreme) where the error can rise significantly. We should examine these results and determine both a reasonable passing criteria (which may depend on the bin) and possible improvements to these integrals.

This should also involve improvements to the interpolation table for the inverse CDF of the conditional mass function (used for sampling). This is currently implemented by interpolating the CDF, however this can get unstable at the rarest masses. We should try to implement a rootfind method which is fast enough to construct this table.

In addition, the inverse CDF table is built with log-probability as it's y-axis for the initial cell sampling, and with probability as it's y-axis for progenitor sampling due to the shape of the CMF as delta approaches the critical value. This is both faster and more accurate for small timesteps but will encounter issues with larger timesteps

@daviesje daviesje added context: v4-prep This issue regards changes to the v4-prep branch type: testing Adds or modifies tests labels Mar 28, 2024
@daviesje daviesje self-assigned this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: v4-prep This issue regards changes to the v4-prep branch type: testing Adds or modifies tests
Projects
Status: In progress
Development

No branches or pull requests

1 participant