Centered hero button text, fixed hero button text location issue on m… #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Github page link @brianadams731 |
|
Closed this as I moved the changes from this request into my PR #86, This is simply because I can only have one GitHub page per repo so I am not able to provide a demo of both of these changes separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Bloody-Buddy 🤩🤩
Please mention the following in order to get PR merged 🙌🏻🙌🏻
This fixes the position of the text in the hero button. The text jumps between the top and bottom of the button when viewed from desktop vs mobile, changing the display to inline flex provides a uniform experience between both and properly centers the text
Before:
After:
