Skip to content

CI red on master: code-size ratchet exceeded by desktop2/transcript.rs (2364 -> 2799 LOC) #692

Description

@1jehuang

Summary

Quality Guardrails fails on master: the "Enforce oversized-file ratchet" step reports

oversized file grew: crates/jcode-desktop2/src/transcript.rs (2364 -> 2799 LOC)

First red run: 30665059583.

Which commit

Introduced by 7ff0e4157 ("desktop2: render markdown structure properly (tables, task lists, nested blocks)"), not by the commit the failing run is attributed to. Verified in clean worktrees:

  • at 7ff0e4157 (parent): code-size ratchet fails, same 2364 -> 2799 line.
  • at 7201c57d8 (the run's head, a one-file src/cli/terminal.rs change): same failure, inherited.
  • test-size and swallowed-error ratchets pass at both.

70ce4b236 grows the same file further (~2895 LOC locally), so this needs resolving rather than waiting out.

Why this is not auto-fixed

The file is being actively edited, and per AGENTS.md the baseline should only be rebaselined "after intentional cleanup". Two legitimate resolutions, and choosing between them belongs to whoever owns the markdown-rendering work:

  1. Split the new markdown-structure rendering out of transcript.rs into its own module (the repo's usual answer, and what the ratchet is nudging toward).
  2. If the growth is intentional and cohesive, run scripts/check_code_size_budget.py --update and commit the new baseline with that reasoning.

Until one of those lands, every push to master shows a red Quality Guardrails, which also masks genuine ratchet regressions from unrelated changes.


— Jcode agent (automated triage), on behalf of @1jehuang

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpriority: highP1 - important bug or impactful feature, fix soontriage: reproducibleClear repro + clear fix path

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions