Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to use rustls instead of native-tls #366

Open
tyilo opened this issue Oct 9, 2023 · 2 comments
Open

Add feature to use rustls instead of native-tls #366

tyilo opened this issue Oct 9, 2023 · 2 comments

Comments

@tyilo
Copy link
Contributor

tyilo commented Oct 9, 2023

No description provided.

@rageshkrishna
Copy link
Contributor

This would be super useful for me, too. Is there a reason to prefer native-tls over rustls these days?

@GaryCraft GaryCraft mentioned this issue Mar 30, 2024
Open
@ctrlaltf24
Copy link
Collaborator

ctrlaltf24 commented Sep 20, 2024 •
edited
Loading

See PR ctrlaltf24@76f9be1

ctrlaltf24 added a commit to ctrlaltf24/rust-socketio that referenced this issue Sep 20, 2024
@ctrlaltf24
feat: add features for other tls types
76f9be1 
Turned out to be rather easy due to all tls being handled by our dependencies.

Don't love the _fallback-tls feature, however with it we can use cargo-all-features,
which helps reduce feature related bugs.

Downside of cargo-all-features is it takes a long time to execute.

Fixes: 1c3t3a#407, 1c3t3a#366
@ctrlaltf24 ctrlaltf24 mentioned this issue Sep 20, 2024
Draft
iduartgomez pushed a commit to nextdata-tech/rust-socketio that referenced this issue Dec 2, 2024
@ctrlaltf24 @iduartgomez
feat: add features for other tls types
b09d376 
Turned out to be rather easy due to all tls being handled by our dependencies.

Don't love the _fallback-tls feature, however with it we can use cargo-all-features,
which helps reduce feature related bugs.

Downside of cargo-all-features is it takes a long time to execute.

Fixes: 1c3t3a#407, 1c3t3a#366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tyilo @rageshkrishna @ctrlaltf24