Skip to content

Add password generation test #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 5, 2025
Merged

Add password generation test #236

merged 15 commits into from
Nov 5, 2025

Conversation

@JillRegan
Copy link
Contributor

@JillRegan JillRegan commented Oct 30, 2025 •
edited
Loading

This PR adds a E2E test for password generation and refactors E2E test helpers to support password_recipe usage.

🎯 Changes

  • Add TestAccItemResourcePasswordGeneration to validate password recipes (length, symbols, digits, letters).
  • Add BuildPasswordRecipeChecks — validate password_recipe and generated password patterns.
  • Support nested map -> block formatting in item_resource_config (for password_recipe).
  • Move helpers into packages for refactoring

🔧 Benefits

  • Adds targeted coverage for password generation logic and ensures generated passwords match requested recipes.
  • Centralizes and reuses attribute and UUID assertions for future E2E tests

@JillRegan JillRegan self-assigned this Oct 30, 2025
@JillRegan JillRegan mentioned this pull request Oct 31, 2025
Merged
Base automatically changed from jill/add-resource-item-tests to main October 31, 2025 17:07
@JillRegan JillRegan marked this pull request as ready for review November 3, 2025 13:54
@JillRegan JillRegan changed the title [DRAFT] Add password generation test Add password generation test Nov 3, 2025
volodymyrZotov
volodymyrZotov reviewed Nov 3, 2025
View reviewed changes
@JillRegan JillRegan merged commit 7f8350e into main Nov 5, 2025
5 checks passed
@JillRegan JillRegan deleted the jill/add-password-generation-test branch November 5, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@volodymyrZotov volodymyrZotov volodymyrZotov approved these changes

Assignees

@JillRegan JillRegan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JillRegan @volodymyrZotov