Skip to content

Support ANT theming #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
abraha2d opened this issue Feb 11, 2019 · 1 comment
Open

Support ANT theming #2

abraha2d opened this issue Feb 11, 2019 · 1 comment
Assignees
@abraha2d
Labels
enhancement New feature or request priority:backburner Lowest priority

Comments

@abraha2d
Copy link
Member

Is your feature request related to a problem? Please describe.
Modifying control colors using styled-components is hard to maintain and may reduce performance.

Describe the solution you'd like
Implement react-app-rewired and customize-cra using ANT's guide to support built-in theming.

Describe alternatives you've considered
N/A.

Additional context
https://ant.design/docs/react/use-with-create-react-app#Advanced-Guides
@abraha2d abraha2d added the enhancement New feature or request label Feb 11, 2019
@abraha2d abraha2d self-assigned this Feb 11, 2019
@abraha2d
Copy link
Member Author

There's a chance we might not need this, instead we can use styled-components ThemeProvider. However it may be good to integrate react-app-rewired and customize-cra anyway.

abraha2d added a commit that referenced this issue Feb 15, 2019
@abraha2d
#2 Add react-app-rewired, customize-cra, babel-plugin-import
0b4900e
abraha2d added a commit that referenced this issue Feb 16, 2019
@abraha2d
#2 Add react-app-rewired, customize-cra, babel-plugin-import
1739f44
@abraha2d abraha2d added the priority:backburner Lowest priority label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abraha2d abraha2d

Labels
enhancement New feature or request priority:backburner Lowest priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abraha2d