Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with yearmonth folders option checked #232

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hugosolar
Copy link

Description of the Change

There's an issue when Wordpress doesn't use the year/month file structure in the uploads folders, when trying to upload intermediate images to the container, $upload_folder_path is wrongly set to / ./ and that causes the image doesn't get uploaded and by consequence, just the original file is getting uploaded correctly.
By checking if the option is disabled we can set $upload_folder_path to / which fixes the issue

This fix closes #229

How to test the Change

  • Go to Settings > Media and uncheck "Organize my uploads into month- and year-based folders" option
  • Go to Media
  • Upload an image
  • Check the container
  • All intermediate images should be there

Changelog Entry

Fixed - Bug fix
Fixed issue with unchecking year/month option under Settings > Media causes intermediate images not being uploaded to the container

Credits

Props @hugosolar, @glowmedia (for testing and reporting)

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 4.5.0 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest releases not creating image sizes
2 participants