Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change block category to be one of the core defaults #223

Closed
fabiankaegy opened this issue Aug 30, 2024 · 1 comment · Fixed by #226
Closed

Change block category to be one of the core defaults #223

fabiankaegy opened this issue Aug 30, 2024 · 1 comment · Fixed by #226
Assignees
@kirtangajjar
Labels
help wanted Extra attention is needed type:bug Something isn't working. type:good-first-issue Good for newcomers.
Milestone
2.3.0

Comments

@fabiankaegy
Copy link
Member

Currently the "Inline SVG" block bundled with this plugin shows under the "Uncategorized" category in the block inserter. This is because the category is set to safe-svg-blocks:

safe-svg/includes/blocks/safe-svg/block.json

Line 8 in c0e180d

"category": "safe-svg-blocks",

We should change this to use one of the core categories.

My recommendation would be design
@fabiankaegy fabiankaegy added type:bug Something isn't working. type:good-first-issue Good for newcomers. labels Aug 30, 2024
@jeffpaul jeffpaul added this to the 2.3.0 milestone Aug 30, 2024
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Aug 30, 2024
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Aug 30, 2024
kirtangajjar added a commit that referenced this issue Sep 15, 2024
@kirtangajjar
Merge remote-tracking branch 'origin/develop' into feature/GH-223
ebb3051
@kirtangajjar kirtangajjar mentioned this issue Sep 15, 2024
Merged
4 tasks
@kirtangajjar
Copy link
Member

@dkotter Created a PR for it - #226. It can be CRed now.

@kirtangajjar kirtangajjar moved this from To Do to In Progress in Open Source Practice Sep 15, 2024
jeffpaul added a commit that referenced this issue Sep 15, 2024
@jeffpaul
Merge pull request #226 from 10up/feature/GH-223
a63a077 
Change block category to design
@github-project-automation github-project-automation bot moved this from In Progress to Done in Open Source Practice Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirtangajjar kirtangajjar

Labels
help wanted Extra attention is needed type:bug Something isn't working. type:good-first-issue Good for newcomers.
Projects
Open Source Practice
Archived in project
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

Change block category to design 10up/safe-svg
3 participants
@jeffpaul @kirtangajjar @fabiankaegy