-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to change skin on player #5
Comments
I've added a block setting where you can paste in any valid skin URL: These URLs come from going to https://skins.webamp.org/ and then clicking on any skin. You then copy the resulting URL and paste that into this new field. This is then parsed on the FE to load the correct skin: Not exactly sure if this is the approach we want to go with or not, so look at this more of a proof of concept that we can change if desired. |
@dkotter that's awesome, nice work! The next question will be how to potentially load a custom skin if we're unable to get the one that @melchoyce is helping to create published on the skins.webamp.org site? |
Couple options that come to mind:
|
It looks like we may be able to submit our custom skin via https://skins.webamp.org/upload/ and then link to that similarly to linking to other skins in the library. |
We could have some skins as options in a single select at launch with the basic winamp skin as default, but figure out a graceful UX way to allow folks to select other skins in the library. Though a simple URL field also generally achieves that as well. |
I'd like to see us have a small set of skins easily selectable, either as a dropdown with their names displayed or (ideally better) thumbnails of each selectable, and then an advanced option to enter the skin URL (current functionality). The subset of default skins would be the 4 in the first list in the description of #1 (with ideally a custom skin crafted in that issue to be added later). Obviously if someone is passionate enough about another skin(s) being a default option then I'm open to that as well. |
Is your enhancement related to a problem? Please describe.
This is probably best left as a block setting and not something we'd need to worry about supporting on the site front-end. We should be able to test with available skins in the Winamp Skin Museum, but will want to determine if the way the webamp player works is that it expects skins to be in the Winamp Skin Museum or if they can be provided from within the same domain that the webamp player is rendered on (i.e., the site this plugin will be installed on and thus whether the plugin needs to be bundled with the skins or if the skins can be selected / linked from the Winamp Skin Museum).
Describe the solution you'd like
Designs
See #1
Describe alternatives you've considered
Only provide initial support for a single, default skin.
Additional context
n/a
The text was updated successfully, but these errors were encountered: