Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change skin on player #5

Closed
3 tasks
jeffpaul opened this issue Nov 6, 2021 · 6 comments · Fixed by #60
Closed
3 tasks

Add ability to change skin on player #5

jeffpaul opened this issue Nov 6, 2021 · 6 comments · Fixed by #60
Assignees
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Milestone

Comments

@jeffpaul
Copy link
Member

jeffpaul commented Nov 6, 2021

Is your enhancement related to a problem? Please describe.
This is probably best left as a block setting and not something we'd need to worry about supporting on the site front-end. We should be able to test with available skins in the Winamp Skin Museum, but will want to determine if the way the webamp player works is that it expects skins to be in the Winamp Skin Museum or if they can be provided from within the same domain that the webamp player is rendered on (i.e., the site this plugin will be installed on and thus whether the plugin needs to be bundled with the skins or if the skins can be selected / linked from the Winamp Skin Museum).

Describe the solution you'd like

  • figure out how to switch a skin within the current player
  • figure out whether skins have to be on the remote Winamp Skin Museum, have to be available on the same domain the webamp player is rendered on, or both (or something else perhaps?)
  • figure out how to allow a custom skin to be displayed on the player if we're unable to get our custom skin added to the Winamp Skin Museum

Designs
See #1

Describe alternatives you've considered
Only provide initial support for a single, default skin.

Additional context
n/a

@jeffpaul jeffpaul added the type:enhancement New feature or request. label Nov 6, 2021
@jeffpaul jeffpaul added this to the 1.0.0 milestone Nov 6, 2021
@dkotter
Copy link
Collaborator

dkotter commented Nov 9, 2021

I've added a block setting where you can paste in any valid skin URL:

Screen Shot 2021-11-08 at 9 49 16 PM

These URLs come from going to https://skins.webamp.org/ and then clicking on any skin. You then copy the resulting URL and paste that into this new field.

This is then parsed on the FE to load the correct skin:

Screen Shot 2021-11-08 at 9 49 31 PM

Not exactly sure if this is the approach we want to go with or not, so look at this more of a proof of concept that we can change if desired.

@jeffpaul
Copy link
Member Author

jeffpaul commented Nov 9, 2021

@dkotter that's awesome, nice work! The next question will be how to potentially load a custom skin if we're unable to get the one that @melchoyce is helping to create published on the skins.webamp.org site?

@dkotter
Copy link
Collaborator

dkotter commented Nov 9, 2021

Couple options that come to mind:

  1. Right now if no skin URL is entered, we just load whatever default skin comes with the player. We could make the custom skin the default instead and bundle that skin with the plugin
  2. If we don't want it to be the default, we could still bundle the skin but then have a toggle to turn that skin on (and probably hide the skin URL input)
  3. We could go fancier and have an upload field allowing any custom skin file to be used. We would have to add support for .wsz files to WordPress but this would allow any custom skin to be used. Not sure it's worth the effort and also doesn't solve how other people will download this custom skin to use in the first place

@jeffpaul
Copy link
Member Author

It looks like we may be able to submit our custom skin via https://skins.webamp.org/upload/ and then link to that similarly to linking to other skins in the library.

@jeffpaul
Copy link
Member Author

We could have some skins as options in a single select at launch with the basic winamp skin as default, but figure out a graceful UX way to allow folks to select other skins in the library. Though a simple URL field also generally achieves that as well.

@jeffpaul jeffpaul modified the milestones: 1.0.0, 1.1.0 Nov 18, 2021
@Sidsector9 Sidsector9 modified the milestones: 1.1.0, 1.2.0 Jun 21, 2022
@jeffpaul jeffpaul moved this to Incoming in Open Source Practice Jun 28, 2022
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Jun 28, 2022
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jun 28, 2022
@jeffpaul
Copy link
Member Author

I'd like to see us have a small set of skins easily selectable, either as a dropdown with their names displayed or (ideally better) thumbnails of each selectable, and then an advanced option to enter the skin URL (current functionality). The subset of default skins would be the 4 in the first list in the description of #1 (with ideally a custom skin crafted in that issue to be added later). Obviously if someone is passionate enough about another skin(s) being a default option then I'm open to that as well.

@zamanq zamanq self-assigned this Aug 25, 2022
@zamanq zamanq moved this from To Do to In Progress in Open Source Practice Aug 26, 2022
@jeffpaul jeffpaul moved this from In Progress to In Review in Open Source Practice Sep 12, 2022
Repository owner moved this from In Review to Merged in Open Source Practice Oct 14, 2022
@jeffpaul jeffpaul modified the milestones: 1.2.0, 1.1.1 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants