Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Stylesheet does not need to be loaded outside of SCRIPT_DEBUG mode #174

Closed
1 task done
davisshaver opened this issue Dec 17, 2023 · 0 comments · Fixed by #178
Closed
1 task done

Editor Stylesheet does not need to be loaded outside of SCRIPT_DEBUG mode #174

davisshaver opened this issue Dec 17, 2023 · 0 comments · Fixed by #178
Assignees
@davisshaver
Labels
help wanted Extra attention is needed type:bug Something isn't working.
Milestone
1.3.4

Comments

@davisshaver
Copy link
Contributor

davisshaver commented Dec 17, 2023 •
edited
Loading

Describe the bug

I was tracking down a console error seen on a Newspack site using Publisher Media Kit.

tinymce.min.js:2 
       GET https://domain.com/wp-content/plugins/publisher-media-kit/dist/css/editor-style.min.css?wp-mce-49110-20201110 net::ERR_ABORTED 404 (Not Found)

This file does not appear to be built. It is not listed in the entrypoints: https://github.com/10up/publisher-media-kit/blob/develop/package.json#L60-L69

Should editor style be added as its own entrypoint to support this code? https://github.com/10up/publisher-media-kit/blob/develop/includes/core.php#L338-L353

Steps to Reproduce

Load New Post page with plugin enabled. Do not have SCRIPT_DEBUG enabled. Observe the 404.

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@davisshaver davisshaver added the type:bug Something isn't working. label Dec 17, 2023
@jeffpaul jeffpaul moved this from Incoming to Backlog in Open Source Practice Dec 18, 2023
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jan 11, 2024
@jeffpaul jeffpaul added this to the Future Release milestone Jan 11, 2024
@davisshaver davisshaver mentioned this issue Jan 15, 2024
Merged
4 tasks
@jeffpaul jeffpaul moved this from Backlog to In Review in Open Source Practice Jan 16, 2024
@jeffpaul jeffpaul modified the milestones: Future Release, 1.3.4 Jan 16, 2024
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davisshaver davisshaver

Labels
help wanted Extra attention is needed type:bug Something isn't working.
Projects
Open Source Practice
Archived in project
Milestone
1.3.4
Development

Successfully merging a pull request may close this issue.

fix: add editor-style entrypoint davisshaver/publisher-media-kit
3 participants
@davisshaver @jeffpaul @faisal-alvi