Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore sharing our Media Kit blocks/patterns with the WP.ORG Pattern Directory #132

Open
1 task done
jeffpaul opened this issue Feb 16, 2023 · 6 comments
Open
1 task done
Labels
help wanted Extra attention is needed type:enhancement New feature or request.

Comments

@jeffpaul
Copy link
Member

Is your enhancement related to a problem? Please describe.

We’re looking to take the blocks that are included in the media kit page created by the plugin (see screenshots in the readme file) and then craft each of those blocks (except for the tab blocks one as there’s nothing to base that on currently in core) as block patterns. Our hope is that each of those blocks, tab ones not included, can get into a pattern that we can then submit to the WP.org Block Pattern Directory via the 10up account.

Designs

See existing block/pattern designs within the plugin itself (or screenshots from README.md).

Describe alternatives you've considered

n/a

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Feb 16, 2023
@jeffpaul jeffpaul added this to the Future Release milestone Feb 16, 2023
@jeffpaul jeffpaul moved this from Incoming to Backlog in Open Source Practice Feb 16, 2023
@barneyjeffries
Copy link

patterns.zip

@jeffpaul I have taken a first pass at the block patterns - see link to attached zip file with the HTML for each. I have got as close as possible using the standard block styling options, plus a few inline CSS styles.

@faisal-alvi
Copy link
Member

@barneyjeffries Great! Have you confirmed that the WP Block Pattern Directory would accept the same HTML? You may check it out at https://wordpress.org/patterns/new-pattern if you haven't already.

@barneyjeffries
Copy link

@faisal-alvi I have gone through and copied the patterns into the WP pattern editor and it seems to accept the patterns successfully.

@jeffpaul
Copy link
Member Author

Noting that @jamespstyles will also help test those patterns and see if there are any further tweaks to improve things there before we submit

@jamespstyles
Copy link

Hi @jeffpaul I've made some small adjustment to the patterns that @barneyjeffries started. Please find the tweaked patterns attached.

patterns-tweaked.zip

Specific updates included:

  • Specifying white text colours on the "cover.html" block
    -- I noticed that in when activating the core Twenty Twenty-Three theme the text was black
  • Improving the alignment and simplicity of the tick bullet points in the "our-packages.html" by using the Unicode “✓” Character instead of an image
  • Added separators in the "our-packages.html" under the tick list.
  • Reworked "question-block.html" removing the dependancy on "Publisher Media Kit" being installed and active by remove the pmk-question-block class.
  • Tweaked "stats.html" to slightly improve the spacing of each stat by introducing a group block.

I think we're getting pretty close to what we can achieve with the standard block styling options - and it's a shame that we're missing some simple things border-radius styling and some of the custom background styles, but hopefully these patterns may be useful nonetheless!

@jeffpaul
Copy link
Member Author

@fabiankaegy curious for your take on the areas lacking here and if waiting a bit will make those more feasible or if we're better served by sharing these patterns now?

@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

4 participants