Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If 'Block for Apple Maps' plugin is disabled and page has block added then page has block markup #109

Open
1 task done
ankitguptaindia opened this issue Jan 26, 2022 · 2 comments
Open
1 task done

If 'Block for Apple Maps' plugin is disabled and page has block added then page has block markup #109

ankitguptaindia opened this issue Jan 26, 2022 · 2 comments
Labels
help wanted Extra attention is needed needs:discussion This requires discussion to determine next steps. needs:engineering This requires engineering to resolve. type:bug Something isn't working.
Milestone
Future Release

Comments

@ankitguptaindia
Copy link
Member

Describe your question

I am not sure this is intentional or not so sharing here as a question.

If pages/posts have 'Apple Maps block' added in the content area and if admin disabled plugin from plugins setting for any reason then all pages/posts have Blank space in frontend.
I believe, if the plugin is disabled then blank space should not show between the content in the frontend.

Please feel free to close this issue if this is intentional for any other logic.

Blank.Space.mp4

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ankitguptaindia ankitguptaindia added the type:question Further information is requested. label Jan 26, 2022
@ankitguptaindia ankitguptaindia changed the title If Block for Apple Maps plugin is disabled and page has block added then page has block markup If 'Block for Apple Maps' plugin is disabled and page has block added then page has block markup Jan 26, 2022
@fabiankaegy
Copy link
Member

I would argue that this is intentional. The editor decided to add the height to the block and used it for consistent spacing. Of course, no longer having the block on the page the gap is odd. But it continues to occupy the space that was added for it.

But totally open for discussion around this :) I'm not sure there is a best answer for it jet.

@jeffpaul jeffpaul added this to the Future Release milestone Jan 26, 2022
@jeffpaul jeffpaul added needs:discussion This requires discussion to determine next steps. needs:engineering This requires engineering to resolve. type:bug Something isn't working. and removed type:question Further information is requested. labels Jan 26, 2022
@jeffpaul jeffpaul moved this to Incoming in Open Source Practice Jan 26, 2022
@jeffpaul jeffpaul moved this from Incoming to Backlog in Open Source Practice Jan 26, 2022
@RuhaniMakhija
Copy link

Hello I would like to work on this issue

@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed needs:discussion This requires discussion to determine next steps. needs:engineering This requires engineering to resolve. type:bug Something isn't working.
Projects
None yet
Milestone
Future Release
Development

No branches or pull requests
4 participants
@jeffpaul @ankitguptaindia @fabiankaegy @RuhaniMakhija