Merge pull request #281 from 10up/develop

Release 2.7.0

Author: oscarssanchez

CHANGELOG.md

@@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file, per [the Ke
 
 ## [Unreleased] - TBD
 
+## [2.7.0] - 2022-06-29
+
+### Fixed
+- Picture in Picture not working. Props [@oscarssanchez](https://github.com/oscarssanchez), and [@felipeelia](https://github.com/felipeelia), via [#272](https://github.com/10up/brightcove-video-connect/pull/272).
+
+### Added
+
+- Enable audio track language detection based on browser language if video has multiple audio tracks. Props [@oscarssanchez](https://github.com/oscarssanchez), and [@felipeelia](https://github.com/felipeelia), via [#279](https://github.com/10up/brightcove-video-connect/pull/279).
+
 ## [2.6.1] - 2022-06-07
 
 ### Fixed
@@ -372,6 +381,7 @@ All notable changes to this project will be documented in this file, per [the Ke
 - First release
 
 [Unreleased]: https://github.com/10up/brightcove-video-connect/compare/master...develop
+[2.7.0]: https://github.com/10up/brightcove-video-connect/compare/2.6.1...2.7.0
 [2.6.1]: https://github.com/10up/brightcove-video-connect/compare/2.6.0...2.6.1
 [2.6.0]: https://github.com/10up/brightcove-video-connect/compare/2.5.2...2.6.0
 [2.5.2]: https://github.com/10up/brightcove-video-connect/compare/2.5.1...2.5.2

README.md

@@ -104,6 +104,12 @@ http://httpd.apache.org/docs/current/mod/core.html#limitrequestbody (LimitReques
 14. Selecting a playlist to show the details on the sidebar.
 ![](/.wordpress-org/screenshot-14.png)
 
+## Audio Track Language Detection
+
+The plugin has the ability to auto determine audio track language detection if the option has been enabled, based on the user browser language.
+
+However, in order for it to work you need to make sure you have multiple audio tracks available in Brightcove Studio for the video you want to enable this option, otherwise, this feature won't work.
+
 ## Support Level
 
 **Active:** 10up is actively working on this, and we expect to continue work for the foreseeable future including keeping tested up to the most recent version of WordPress.  Bug reports, feature requests, questions, and pull requests are welcome.

assets/css/brightcove_video_connect.css

@@ -504,6 +504,8 @@ div.brightcove-uploader div.brightcove-messages .updated {
     clear: both; }
   .brightcove.media-frame-menu .attachment-detail .video-details input[type=number], .brightcove.media-frame-menu .attachment-detail .playlist-details input[type=number], .brightcove.media-frame-menu .attachment-detail .inpageexperiences-details input[type=number] {
     width: 20%; }
+  .brightcove.media-frame-menu .attachment-detail .video-details input[type=checkbox], .brightcove.media-frame-menu .attachment-detail .playlist-details input[type=checkbox], .brightcove.media-frame-menu .attachment-detail .inpageexperiences-details input[type=checkbox] {
+    margin-left: 10px; }
   .brightcove.media-frame-menu .attachment-detail .video-details textarea, .brightcove.media-frame-menu .attachment-detail .playlist-details textarea, .brightcove.media-frame-menu .attachment-detail .inpageexperiences-details textarea {
     margin-top: 10px;
     width: 100%; }

assets/css/brightcove_video_connect.min.css

@@ -42,6 +42,7 @@
 			var autoplay = props.attributes.autoplay || '';
 			var playsinline = props.attributes.playsinline || '';
 			var pictureinpicture = props.attributes.picture_in_picture || '';
+			var languageDetection = props.attributes.language_detection || '';
 			var embed = props.attributes.embed || '';
 			var mute = props.attributes.mute || '';
 			var sizing = props.attributes.sizing || 'responsive';
@@ -201,6 +202,7 @@
 					mute: '',
 					playsinline: '',
 					picture_in_picture: '',
+					languageDetection: '',
 					embed: attrs.named.embed,
 					sizing: attrs.named.sizing,
 					aspect_ratio: attrs.named.aspect_ratio,
@@ -213,6 +215,7 @@
 					setAttrs.mute = attrs.named.mute;
 					setAttrs.playsinline = attrs.named.playsinline;
 					setAttrs.picture_in_picture = attrs.named.picture_in_picture;
+					setAttrs.language_detection = attrs.named.language_detection;
 					setAttrs.padding_top = attrs.named.padding_top;
 				} else if (attrs.numeric[0] === '[bc_playlist') {
 					setAttrs.player_id = attrs.named.player_id;
@@ -482,7 +485,18 @@
 									});
 								},
 							}),
-						pictureinpicture === 'pictureinpicture'
+						el(components.CheckboxControl, {
+							label: __('Enable Language Detection', 'brightcove'),
+							checked: languageDetection,
+							onChange: function (value) {
+								props.setAttributes({
+									...props.attributes,
+									language_detection: value && 'languagedetection',
+								});
+							},
+						}),
+						languageDetection === 'languagedetection' ||
+							pictureinpicture === 'pictureinpicture'
 							? el(
 									components.Disabled,
 									{ style: { marginBottom: '24px' } },

assets/js/brightcove-admin.js

@@ -18,10 +18,11 @@ var MediaDetailsView = BrightcoveView.extend({
 		'click .brightcove.back.button': 'triggerCancelPreviewMedia',
 		'click .playlist-details input[name="embed-style"]': 'togglePlaylistSizing',
 		'change #aspect-ratio': 'toggleUnits',
-		'change #pictureinpicture': 'togglePictureinpicture',
+		'change #pictureinpicture': 'toggleIframe',
+		'change #languagedetection': 'toggleIframe',
 		'change .experience-details input[name="sizing"],.experience-details input[name="embed-style"]':
 			'toggleExperienceUnits',
-		'change #video-player, #autoplay, #pictureinpicture, #playsinline, #mute, input[name="embed-style"], input[name="sizing"], #aspect-ratio, #width, #height':
+		'change #video-player, #autoplay, #pictureinpicture, #languagedetection, #playsinline, #mute, input[name="embed-style"], input[name="sizing"], #aspect-ratio, #width, #height':
 			'generateShortcode',
 		'change #generate-shortcode': 'toggleShortcodeGeneration',
 	},
@@ -73,11 +74,14 @@ var MediaDetailsView = BrightcoveView.extend({
 		}
 	},
 
-	togglePictureinpicture: function (event) {
+	toggleIframe: function (event) {
 		var $iframeRadioButton = $('#embed-style-iframe'),
-			$pictureinpicture_checked = $('#pictureinpicture').is(':checked');
+			notAllowedOptions = [
+				$('#pictureinpicture').is(':checked'),
+				$('#languagedetection').is(':checked'),
+			];
 
-		if ($pictureinpicture_checked) {
+		if (notAllowedOptions.includes(true)) {
 			$iframeRadioButton.prop('checked', false);
 			$iframeRadioButton.attr('disabled', true);
 		} else {
@@ -137,6 +141,7 @@ var MediaDetailsView = BrightcoveView.extend({
 			autoplay = $('#autoplay').is(':checked') ? 'autoplay' : '',
 			playsinline = $('#playsinline').is(':checked') ? 'playsinline' : '',
 			pictureinpicture = $('#pictureinpicture').is(':checked') ? 'pictureinpicture' : '',
+			languagedetection = $('#languagedetection').is(':checked') ? 'languagedetection' : '',
 			mute = $('#mute').is(':checked') ? 'muted' : '',
 			embedStyle = $('input[name="embed-style"]:checked').val(),
 			sizing = $('input[name="sizing"]:checked').val(),
@@ -190,6 +195,8 @@ var MediaDetailsView = BrightcoveView.extend({
 			playsinline +
 			'" picture_in_picture="' +
 			pictureinpicture +
+			'" language_detection="' +
+			languagedetection +
 			'" max_width="' +
 			maxWidth +
 			'" ' +

assets/js/brightcove-admin.js.map

@@ -336,6 +336,10 @@
 				width: 20%;
 			}
 
+			input[type=checkbox] {
+				margin-left: 10px;
+			}
+
 			textarea {
 				margin-top: 10px;
 				width: 100%;