From 35272973a5e41ef05b259a1b2104fca11db81498 Mon Sep 17 00:00:00 2001 From: Burhan Nasir Date: Wed, 27 Mar 2024 13:09:19 +0500 Subject: [PATCH] Fix: Update call fail when labels are empty (#381) --- assets/js/src/views/video-edit.js | 3 ++- includes/admin/api/class-bc-admin-media-api.php | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/assets/js/src/views/video-edit.js b/assets/js/src/views/video-edit.js index ffd0d056..3fd7b067 100644 --- a/assets/js/src/views/video-edit.js +++ b/assets/js/src/views/video-edit.js @@ -385,7 +385,8 @@ var VideoEditView = BrightcoveView.extend({ this.model.set('captions', captions); // Labels - const labels = this.$el.find('.bc-labels-value').val()?.split(',') || []; + let labels = this.$el.find('.bc-labels-value').val(); + labels = labels !== '' ? labels.split(',') : []; this.model.set('labels', labels); // Custom fields diff --git a/includes/admin/api/class-bc-admin-media-api.php b/includes/admin/api/class-bc-admin-media-api.php index 6f9fbb42..0c1d9c0d 100644 --- a/includes/admin/api/class-bc-admin-media-api.php +++ b/includes/admin/api/class-bc-admin-media-api.php @@ -173,7 +173,7 @@ public function bc_ajax_update_video_or_playlist() { $labels = array(); if ( isset( $_POST['labels'] ) ) { - foreach ( $_POST['labels'] as $label ) { + foreach ( array_filter( $_POST['labels'] ) as $label ) { $labels[] = sanitize_text_field( $label ); } }