Skip to content

Commit 07d556f

Browse files
authored
Merge pull request #206 from 10up/fix/search-field-clear-results
Clear filtered results when input search is empty
2 parents c265eec + ac4cbcf commit 07d556f

File tree

5 files changed

+68
-48
lines changed

5 files changed

+68
-48
lines changed

assets/js/brightcove-admin.js

Lines changed: 31 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

assets/js/brightcove-admin.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

assets/js/brightcove-admin.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

assets/js/src/views/toolbar.js

Lines changed: 31 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,19 @@ var ToolbarView = BrightcoveView.extend(
99
template : wp.template( 'brightcove-media-toolbar' ),
1010

1111
events : {
12-
'click .view-list': 'toggleList',
13-
'click .view-grid': 'toggleGrid',
14-
'click .brightcove-toolbar': 'toggleToolbar',
15-
'change .brightcove-media-source': 'sourceChanged',
16-
'change .brightcove-media-dates': 'datesChanged',
17-
'change .brightcove-media-tags': 'tagsChanged',
18-
'change .brightcove-media-folders': 'foldersChanged',
19-
'change .brightcove-media-labels': 'labelsChanged',
20-
'change .brightcove-empty-playlists': 'emptyPlaylistsChanged',
21-
'change .brightcove-media-state-filters': 'stateChanged',
22-
'click #media-search': 'searchHandler',
23-
'keyup .search': 'enterHandler'
12+
'click .view-list': 'toggleList',
13+
'click .view-grid': 'toggleGrid',
14+
'click .brightcove-toolbar': 'toggleToolbar',
15+
'change .brightcove-media-source': 'sourceChanged',
16+
'change .brightcove-media-dates': 'datesChanged',
17+
'change .brightcove-media-tags': 'tagsChanged',
18+
'change .brightcove-media-folders': 'foldersChanged',
19+
'change .brightcove-media-labels': 'labelsChanged',
20+
'change .brightcove-empty-playlists': 'emptyPlaylistsChanged',
21+
'change .brightcove-media-state-filters': 'stateChanged',
22+
'click #media-search': 'searchHandler',
23+
'keyup .search': 'enterHandler',
24+
'input #media-search-input': 'handleEmptySearchInput'
2425
},
2526

2627
render : function () {
@@ -101,11 +102,11 @@ var ToolbarView = BrightcoveView.extend(
101102
wpbc.broadcast.trigger( 'change:tag', event.target.value );
102103
},
103104

104-
foldersChanged: function (event) {
105-
this.model.set('oldFolderId', this.model.get('folderId'));
106-
this.model.set('folderId', event.target.value);
107-
wpbc.broadcast.trigger('change:folder', event.target.value);
108-
},
105+
foldersChanged: function (event) {
106+
this.model.set('oldFolderId', this.model.get('folderId'));
107+
this.model.set('folderId', event.target.value);
108+
wpbc.broadcast.trigger('change:folder', event.target.value);
109+
},
109110

110111
labelsChanged: function ( event ) {
111112
this.model.set( 'oldLabelPath', this.model.get( 'labelPath' ) );
@@ -118,11 +119,18 @@ var ToolbarView = BrightcoveView.extend(
118119
wpbc.broadcast.trigger( 'change:emptyPlaylists', emptyPlaylists );
119120
},
120121

121-
enterHandler : function ( event ) {
122-
if ( event.keyCode === 13 ) {
123-
this.searchHandler( event );
124-
}
125-
},
122+
enterHandler : function ( event ) {
123+
if ( event.keyCode === 13 ) {
124+
this.searchHandler( event );
125+
}
126+
},
127+
128+
handleEmptySearchInput : function ( event ) {
129+
if (this.model.get( 'search' ) && !event.target.value) {
130+
this.model.set('search', '');
131+
wpbc.broadcast.trigger( 'change:searchTerm', '' );
132+
}
133+
},
126134

127135
stateChanged : function( event ) {
128136
this.model.set('oldState', 'oldstate');
@@ -137,7 +145,7 @@ var ToolbarView = BrightcoveView.extend(
137145
this.model.set( 'search', searchTerm );
138146
wpbc.broadcast.trigger( 'change:searchTerm', searchTerm );
139147
} else if (searchTerm.length === 0) {
140-
wpbc.broadcast.trigger( 'change:searchTerm', "" );
148+
wpbc.broadcast.trigger( 'change:searchTerm', "" );
141149
}
142150
}
143151
}

package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@
99
"name": "10up",
1010
"email": "[email protected]"
1111
},
12+
"scripts": {
13+
"watch": "grunt watch",
14+
"build": "grunt build"
15+
},
1216
"dependencies": {},
1317
"devDependencies": {
1418
"grunt": "^1.0.4",

0 commit comments

Comments
 (0)