Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try replacing DND-Kit with core Draggable component #315

Open
fabiankaegy opened this issue Apr 30, 2024 · 6 comments
Open

Try replacing DND-Kit with core Draggable component #315

fabiankaegy opened this issue Apr 30, 2024 · 6 comments
Assignees
Labels
Good First Issue Good for newcomers [Type] Enhancement New feature or request

Comments

@fabiankaegy
Copy link
Member

I just stumbled across the fact that core has a Draggable component. It would be great to not have to include / bundle all of DND-Kit in the block components and instead leverage the bundled solution

@fabiankaegy fabiankaegy added [Type] Enhancement New feature or request Good First Issue Good for newcomers labels Apr 30, 2024
@Sidsector9 Sidsector9 self-assigned this Aug 9, 2024
@Sidsector9
Copy link
Member

I've tried working in this one last week, then found Draggable does not work inside the block editor.

@fabiankaegy
Copy link
Member Author

@Sidsector9
Copy link
Member

@fabiankaegy yep, that's the component I was trying to use.

@fabiankaegy
Copy link
Member Author

Hmm okay that is annoying then

@Sidsector9
Copy link
Member

I'm working on a Vanilla JS solution for reordering in React Components. This'll help to not use Dnd-kit. This is working in a simple React App, trying to figure out how best to use it with a component like Repeater.

Screen.Recording.2024-08-19.at.1.16.59.PM.mov

@Sidsector9
Copy link
Member

Sidsector9 commented Aug 19, 2024

Update

This is working well within Inspector Controls, but not within blocks.

Note: There's something weird going on. Whenever Yoast is disabled, Repeater (develop branch) breaks. I'm not sure why.

Screen.Recording.2024-08-19.at.6.09.26.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers [Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants