Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Video #220

Open
1 task done
benlk opened this issue May 23, 2023 · 3 comments · May be fixed by #225
Open
1 task done

Component: Video #220

benlk opened this issue May 23, 2023 · 3 comments · May be fixed by #225
Assignees
@benlk
Labels
New Component [Type] Enhancement New feature or request

Comments

@benlk
Copy link
Contributor

benlk commented May 23, 2023

Is your enhancement related to a problem? Please describe.

We have an Image component that provides a way to upload an image, show it, and handle placeholders if no image has been uploaded.

Can we get the same thing for video content?

(Yes, it's often better to use an third-party embed for video content, but some client requirements sometimes require uploads direct to WordPress)

Designs

No response

Describe alternatives you've considered

I'll be writing an attempt at this for a client project, and will provide that as a PR for this project.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fabiankaegy
Copy link
Member

Looking forward to your PR :)

@fabiankaegy fabiankaegy added [Type] Enhancement New feature or request and removed type:enhancement labels May 24, 2023
@fabiankaegy fabiankaegy changed the title Component request: Video Component: Video May 24, 2023
@benlk
Copy link
Contributor Author

benlk commented Jun 1, 2023

Status update: doing a bunch of code review revisions over on the project that I built this for; will open a PR here when that's approved.

@benlk benlk linked a pull request Jun 2, 2023 that will close this issue
Draft
9 tasks
@benlk
Copy link
Contributor Author

benlk commented Jun 2, 2023

PR added, with questions: #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlk benlk

Labels
New Component [Type] Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New component: Video 10up/block-components
2 participants
@benlk @fabiankaegy