Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP CLI .distignore syntax is changing #139

Open
BrianHenryIE opened this issue Sep 14, 2023 · 2 comments · May be fixed by #148
Open

WP CLI .distignore syntax is changing #139

BrianHenryIE opened this issue Sep 14, 2023 · 2 comments · May be fixed by #148
Assignees
@claytoncollie
Labels
help wanted Extra attention is needed needs:engineering This requires engineering to resolve. type:enhancement New feature or request.
Milestone
2.3.0

Comments

@BrianHenryIE
Copy link

Describe the bug

WP CLI's .distignore files will soon support the full .gitignore syntax. Users who write their .distignore file with the larger syntax will encounter issues with 10up/action-wordpress-plugin-deploy.

wp-cli/dist-archive-command#78

Expected behavior

Users will expect a .distignore file to behave the same in both contexts.

Additional context

There are no breaking changes with the existing syntax, the new syntax is a superset (according to the test cases in wp-cli/dist-archive-command).
@vikrampm1 vikrampm1 added the type:enhancement New feature or request. label Sep 14, 2023
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Sep 14, 2023
@jeffpaul jeffpaul added help wanted Extra attention is needed needs:engineering This requires engineering to resolve. labels Sep 14, 2023
@jeffpaul jeffpaul added this to the 2.3.0 milestone Sep 14, 2023
@claytoncollie claytoncollie linked a pull request Apr 3, 2024 that will close this issue
Open
3 tasks
@claytoncollie
Copy link

@BrianHenryIE I opened #148 to address this issue. Please review the pull request and let me know if you have any feedback. Also, I see this repo was last released in 2020 but items are still being merged into the main branch. Was this feature ever released, if not, when will it be?

@jeffpaul jeffpaul moved this from To Do to Code Review in Open Source Practice Apr 4, 2024
@BrianHenryIE
Copy link
Author

That release was tagged just now. I’m on holidays right now so haven’t had a chance to test anything yet.

https://github.com/wp-cli/dist-archive-command/releases/tag/v3.0.0

@BrianHenryIE BrianHenryIE mentioned this issue Apr 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claytoncollie claytoncollie

Labels
help wanted Extra attention is needed needs:engineering This requires engineering to resolve. type:enhancement New feature or request.
Projects
Open Source Practice
Status: Code Review
Milestone
2.3.0
4 participants
@jeffpaul @claytoncollie @BrianHenryIE @vikrampm1