New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 7 recommendation in migration section #395

Open

1 task done

PypWalters opened this issue Jun 7, 2023 · 0 comments

Open

1 task done

Fix PHP 7 recommendation in migration section #395

PypWalters opened this issue Jun 7, 2023 · 0 comments

Labels

PypWalters commented Jun 7, 2023

Describe the bug

In the migration documentation it says:

Use PHP7
If PHP 7 is an option, use it.

This should either be upped to PHP 8, or removed entirely.

Steps to Reproduce

You can see the text here: https://github.com/10up/Engineering-Best-Practices/blob/gh-pages/_includes/markdown/Migrations.md?plain=1#L132

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

I agree to follow this project's Code of Conduct

PypWalters added the type:bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment