Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve readability of sync output #3990

Closed
wants to merge 4 commits into from
Closed

improve readability of sync output #3990

wants to merge 4 commits into from

Conversation

columbian-chris
Copy link
Contributor

Description of the Change

Closes #3987

How to test the Change

Do a sync via WP-CLI, notice change in output.

Output example (before):

...
Processed posts 40050 - 40200 of 571364. Last Object ID: 2444285
Processed posts 40200 - 40350 of 571364. Last Object ID: 2443651
Processed posts 40350 - 40500 of 571364. Last Object ID: 2443046
Time elapsed: 00:11:14.980000 (+26.058)
Memory Usage: 4978.59mb (Peak: 4982.8mb)
Processed posts 40500 - 40650 of 571364. Last Object ID: 2442462
Processed posts 40650 - 40800 of 571364. Last Object ID: 2441899
Processed posts 40800 - 40950 of 571364. Last Object ID: 2441234
...

Output example (after):

...
Processed posts 34,050 - 34,200 of 571,364. Last Object ID: 2467260
Processed posts 34,200 - 34,350 of 571,364. Last Object ID: 2466652
Processed posts 34,350 - 34,500 of 571,364. Last Object ID: 2466098
Time elapsed: 00:09:26.950000 (+24.593)
Memory Usage: 4.15gb (Peak: 4.15gb)
Processed posts 34,500 - 34,650 of 571,364. Last Object ID: 2465535
Processed posts 34,650 - 34,800 of 571,364. Last Object ID: 2464943
Processed posts 34,800 - 34,950 of 571,364. Last Object ID: 2464404
...

Changelog Entry

Changed - Existing functionality

Credits

Props @columbian-chris

Checklist:

columbian-chris
columbian-chris commented Oct 28, 2024
View reviewed changes
Copy link
Contributor Author

@columbian-chris columbian-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant PHPCS, not eslint.

@felipeelia felipeelia mentioned this pull request Dec 11, 2024
Merged
4 tasks
@felipeelia
Copy link
Member

@columbian-chris I've opened #4042 with the MB/GB part and one of the number_format calls (changed to a number_format_i18n call). For now, we don't want to change the offset, etc., because often people copy and paste those to use as parameter values, and adding commas to it will make people's lives harder.

@felipeelia felipeelia closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

easier to read memory usage
2 participants
@columbian-chris @felipeelia