You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your enhancement related to a problem? Please describe.
Describe the solution you'd like
Some unit tests are testing different cases in one method. For example, testGetDocuments tests retrieving documents, retrieving a document that doesn't exist, and passing an empty id to retrieve a document.
When this test doesn't pass, it's not clear exactly which case have failed:
1) ElasticPressTest\TestElasticsearch::testGetDocuments
Failed asserting that 2 matches expected 3.
So, we could try to split up assertions a little to have more focused tests.
Designs
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered:
Is your enhancement related to a problem? Please describe.
Describe the solution you'd like
Some unit tests are testing different cases in one method. For example, testGetDocuments tests retrieving documents, retrieving a document that doesn't exist, and passing an empty id to retrieve a document.
When this test doesn't pass, it's not clear exactly which case have failed:
1) ElasticPressTest\TestElasticsearch::testGetDocuments Failed asserting that 2 matches expected 3.
So, we could try to split up assertions a little to have more focused tests.
Designs
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: