fix: missing asset field in report table

Author: lukicenturi

frontend/app/src/components/history/events/HistoryEventNote.vue

@@ -94,13 +94,18 @@ function isLinkType(t: any): t is keyof ExplorerUrls {
 
 <style lang="scss" module>
 .address {
-  vertical-align: middle;
+  @apply align-middle;
 
   &__content {
-    background: var(--v-rotki-light-grey-darken1);
-    padding-right: 0.25rem;
-    border-radius: 3rem;
-    margin: 2px;
+    @apply bg-rui-grey-300 pr-1 rounded-full m-0.5;
+  }
+}
+
+:global(.dark) {
+  .address {
+    &__content {
+      @apply bg-rui-grey-800;
+    }
   }
 }
 </style>

frontend/app/src/components/profitloss/ProfitLossEvents.vue

@@ -218,28 +218,28 @@ const css = useCssModule();
       <template #item.free_amount="{ item }">
         <div class="flex items-center justify-between flex-nowrap gap-4">
           <AssetLink
-            v-if="item.asset"
-            :asset="item.asset"
+            v-if="item.assetIdentifier"
+            :asset="item.assetIdentifier"
             link
           >
             <AssetIcon
               class="flex"
-              :identifier="item.asset"
+              :identifier="item.assetIdentifier"
               size="24px"
             />
           </AssetLink>
           <AmountDisplay
             force-currency
             :value="item.freeAmount"
-            :asset="item.asset ? item.asset : ''"
+            :asset="item.assetIdentifier ? item.assetIdentifier : ''"
           />
         </div>
       </template>
       <template #item.taxable_amount="{ item }">
         <AmountDisplay
           force-currency
           :value="item.taxableAmount"
-          :asset="item.asset ? item.asset : ''"
+          :asset="item.assetIdentifier ? item.assetIdentifier : ''"
         />
       </template>
       <template #item.price="{ item }">
@@ -290,12 +290,14 @@ const css = useCssModule();
             :amount="
               item.taxableAmount.isZero() ? item.freeAmount : item.taxableAmount
             "
-            :asset="item.asset"
+            :asset="item.assetIdentifier"
             :chain="getChain(item.location)"
           />
-          <template v-else>
-            {{ item.notes }}
-          </template>
+          <HistoryEventNote
+            v-else
+            :notes="item.notes"
+            :asset="item.assetIdentifier"
+          />
         </div>
       </template>
       <template #item.actions="{ item }">

frontend/app/src/components/profitloss/ReportMissingAcquisitions.vue

@@ -37,10 +37,13 @@ const groupedMissingAcquisitions = computed<MappedGroupedItems[]>(() => {
     const endDate = sortedAcquisitions.at(-1)?.time;
     assert(endDate, 'end date is missing');
 
+    const totalAmountMissing = bigNumberSum(sortedAcquisitions.map(({ missingAmount }) => missingAmount));
+
     return {
       asset: key,
       startDate,
       endDate,
+      totalAmountMissing,
       acquisitions: sortedAcquisitions,
     };
   });
@@ -72,6 +75,15 @@ const headers = computed<DataTableHeader[]>(() => {
         'profit_loss_report.actionable.missing_acquisitions.headers.missing_acquisitions',
       ).toString(),
       value: 'total_missing_acquisition',
+      align: 'end',
+      ...pinnedClass,
+    },
+    {
+      text: t(
+        'profit_loss_report.actionable.missing_acquisitions.headers.total_missing',
+      ).toString(),
+      value: 'total_amount_missing',
+      align: 'end',
       sortable: false,
       ...pinnedClass,
     },
@@ -161,12 +173,17 @@ const isIgnored = (asset: string) => get(isAssetIgnored(asset));
       <template #item.total_missing_acquisition="{ item }">
         {{ item.acquisitions.length }}
       </template>
+      <template #item.total_amount_missing="{ item }">
+        <AmountDisplay
+          class="text-rui-error"
+          :value="item.totalAmountMissing"
+        />
+      </template>
       <template #item.action="{ item }">
         <div class="flex flex-col items-center gap-1">
           <VMenu offset-y>
             <template #activator="{ on }">
               <RuiButton
-                size="sm"
                 variant="text"
                 icon
                 v-on="on"
@@ -243,7 +260,7 @@ const isIgnored = (asset: string) => get(isAssetIgnored(asset));
             </template>
             <template #item.missingAmount="{ item: childItem }">
               <AmountDisplay
-                pnl
+                class="text-rui-error"
                 :value="childItem.missingAmount"
               />
             </template>

frontend/app/src/composables/history/events/notes.ts

@@ -158,6 +158,17 @@ export function useHistoryEventNote() {
           return;
         }
 
+        if (isEvmIdentifier(word)) {
+          const symbol = get(assetSymbol(word));
+          if (symbol) {
+            formats.push({
+              type: NoteType.WORD,
+              word: symbol,
+            });
+            return;
+          }
+        }
+
         formats.push({ type: NoteType.WORD, word });
       });
 

frontend/app/src/locales/en.json

@@ -3837,7 +3837,8 @@
           "found_amount": "Found Amount",
           "missing_acquisitions": "Missing Acquisitions",
           "missing_amount": "Missing Amount",
-          "quick_action": "Quick Action"
+          "quick_action": "Quick Action",
+          "total_missing": "Total Amount Missing"
         },
         "hint": "Some asset acquisitions are missing. You will need to figure out where you bought them and either import or manually create the relevant acquisition events",
         "title": "Missing Acquisitions ({total})",

frontend/app/tests/unit/specs/composables/history/notes.spec.ts

@@ -3,7 +3,12 @@ import { type NoteFormat, NoteType } from '@/composables/history/events/notes';
 
 vi.mock('@/composables/assets/retrieval', () => ({
   useAssetInfoRetrieval: vi.fn().mockReturnValue({
-    assetSymbol: vi.fn().mockImplementation(identifier => identifier),
+    assetSymbol: vi.fn().mockImplementation((identifier) => {
+      if (isEvmIdentifier(identifier))
+        return 'USDC';
+
+      return identifier;
+    }),
   }),
 }));
 
@@ -272,4 +277,23 @@ describe('composables::history/notes', () => {
 
     expect(formatted).toMatchObject(expected);
   });
+
+  it('with evm asset identifier', () => {
+    const notes = 'Sell eip155:1/erc20:0x514910771AF9Ca656af840dff83E8264EcF986CA';
+
+    const formatted = get(formatNotes({ notes }));
+
+    const expected: NoteFormat[] = [
+      {
+        type: NoteType.WORD,
+        word: 'Sell',
+      },
+      {
+        type: NoteType.WORD,
+        word: 'USDC',
+      },
+    ];
+
+    expect(formatted).toMatchObject(expected);
+  });
 });