Use checked rkyv::access
#1737
Open
Use checked rkyv::access
#1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires us to enable the `bytecheck` features of `rkyv` and makes use of the `CheckBytes` trait to do byte validation when dealing with `rkyv` types. In future, if we wish to bring back the unsafe API for those who want performance, we could feature gate that in our sdk.
matthiasgoergens
added a commit
that referenced
this pull request
May 30, 2024
We want to move from `rkyv::access_unchecked` to checked `rkyv::access`. We are trying to make that work in #1737, but it turns out to be non-trivial. Here's some prep work: introduce byte-check and derive Debug for a few of our sdk types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1680
This requires us to enable the
bytecheckfeatures ofrkyvand makesuse of the
CheckBytestrait to do byte validation when dealing withrkyvtypes.In future, if we wish to bring back the unsafe API for those who want performance,
we could feature gate that in our sdk.