Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink how we populate Data when parsing ELF binaries #1528

Open
spiral-ladder opened this issue Apr 11, 2024 · 0 comments
Open

Rethink how we populate Data when parsing ELF binaries #1528

spiral-ladder opened this issue Apr 11, 2024 · 0 comments
Assignees
@matthiasgoergens

Comments

@spiral-ladder
Copy link
Contributor

spiral-ladder commented Apr 11, 2024 •
edited
Loading

Why do we convert first to u64, and then to u32? Can we convert directly to u32?

(I think you only changes as into try_from().unwrap(), but it would be useful to think about this code a bit.)

Originally posted by @matthiasgoergens in #1522 (comment)
@matthiasgoergens matthiasgoergens self-assigned this Apr 11, 2024
@matthiasgoergens matthiasgoergens changed the title Rethink how we populate Data Rethink how we populate Data when parsing ELF binaries Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthiasgoergens matthiasgoergens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthiasgoergens @spiral-ladder