Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NRT annotations. #431

Open
ElektroKill opened this issue Dec 10, 2021 · 1 comment
Open

Add NRT annotations. #431

ElektroKill opened this issue Dec 10, 2021 · 1 comment
Milestone
v4

Comments

@ElektroKill
Copy link
Contributor

ElektroKill commented Dec 10, 2021 •
edited
Loading

Since .NET 6.0 projects by default have NRT(Nullable Reference Types) enabled. dnlib is not yet annotated with the NRT annotations which makes can be a big drawback when it comes to .NET 6.0 development. Adding NRT annotations in dnlib would improve the experience when working with it in .NET 6.0
@wtfsck
Copy link
Contributor

wtfsck commented Dec 11, 2021

I haven't done it yet because null values are used if there's some invalid metadata. If we instead return non-null values, NRT could be enabled. Probably in v4.0, that's probably a breaking change (to not return null).

@wtfsck wtfsck added this to the v4 milestone Dec 12, 2021
@wtfsck wtfsck mentioned this issue Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4
Development

Successfully merging a pull request may close this issue.

Nullable reference types 0xd4d/dnlib
2 participants
@ElektroKill @wtfsck