Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and update zero tracer in reth #791

Open
temaniarpit27 opened this issue Nov 9, 2024 · 7 comments
Open

Validate and update zero tracer in reth #791

temaniarpit27 opened this issue Nov 9, 2024 · 7 comments

Comments

@temaniarpit27
Copy link
Contributor

Integrate jerigon/zero tracer in reth

@0xaatif
Copy link
Contributor

0xaatif commented Nov 9, 2024

Note that this is already implemented in zeth - could you clarify what you intend for this to entail?

@temaniarpit27
Copy link
Contributor Author

temaniarpit27 commented Nov 9, 2024

You mean zero tracer is integrated and tested with zeth completely?

@temaniarpit27 temaniarpit27 changed the title Integrate zero tracer in reth Validate zero tracer in reth Nov 9, 2024
@temaniarpit27 temaniarpit27 changed the title Validate zero tracer in reth Validate and update zero tracer in reth Nov 9, 2024
@Nashtare
Copy link
Collaborator

There's a variant of the zero tracer but it hasn't been tested extensively (especially the complex reversion cases with state updates, like SSTORE going OOG which causes native tracers to crash). We could spin up a node on the extensive test chain to see how it behaves and make it robust.

@temaniarpit27
Copy link
Contributor Author

There's a variant of the zero tracer but it hasn't been tested extensively (especially the complex reversion cases with state updates, like SSTORE going OOG which causes native tracers to crash). We could spin up a node on the extensive test chain to see how it behaves and make it robust.

Sure

@temaniarpit27 temaniarpit27 moved this from Backlog to In Progress in Zero EVM Nov 11, 2024
@0xaatif
Copy link
Contributor

0xaatif commented Nov 11, 2024

Arpit, could you rewrite this issue? I think it at least needs acceptance criteria for me to understand what you mean by this so that I can integrate it into the story of #761.

Also, is this really In Progress, or are you working on #777?

@temaniarpit27
Copy link
Contributor Author

temaniarpit27 commented Nov 11, 2024

Arpit, could you rewrite this issue? I think it at least needs acceptance criteria for me to understand what you mean by this so that I can integrate it into the story of #761.

Also, is this really In Progress, or are you working on #777?

I was about to write the desc for this tomorrow when I was supposed to pick up. I will do it once I will pick up. I moved it to In Progress so the team know which task I am about to pick up
Now actually its not in Progress as we changed hand on 777 so I will make that in Progress and move it to todo

@temaniarpit27 temaniarpit27 moved this from In Progress to Todo in Zero EVM Nov 11, 2024
@temaniarpit27 temaniarpit27 moved this from Todo to Backlog in Zero EVM Nov 13, 2024
@temaniarpit27 temaniarpit27 removed their assignment Nov 19, 2024
@temaniarpit27
Copy link
Contributor Author

temaniarpit27 commented Nov 19, 2024

Currently, we have just a basic setup of zeth working. We need to test various cases written by john and team to check if the current zero tracer works in all cases, which cases fail etc
https://github.com/0xPolygon/jhilliard/tree/main/evm-rpc-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants