feat: Adding seed to web client creation (#688)

Author: julian-demox

CHANGELOG.md

@@ -18,6 +18,7 @@
 * Created functions for creating standard notes and note scripts easily on the web client (#686).
 * [BREAKING] Renamed plural modules to singular (#687).
 * [BREAKING] Made `idxdb` only usable on WASM targets (#685).
+* Added fixed seed option for web client generation (#688)
 * [BREAKING] Updated `init` command in the CLI to receive a `--network` flag (#690).
 
 ### Fixes

crates/web-client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@demox-labs/miden-sdk",
-  "version": "0.6.1-next.3",
+  "version": "0.6.1-next.4",
   "description": "Polygon Miden Wasm SDK",
   "collaborators": [
     "Polygon Miden",

crates/web-client/src/lib.rs

@@ -56,8 +56,20 @@ impl WebClient {
         &mut self,
         node_url: Option<String>,
         prover_url: Option<String>,
+        seed: Option<Vec<u8>>,
     ) -> Result<JsValue, JsValue> {
-        let mut rng = StdRng::from_entropy();
+        let mut rng = match seed {
+            Some(seed_bytes) => {
+                if seed_bytes.len() == 32 {
+                    let mut seed_array = [0u8; 32];
+                    seed_array.copy_from_slice(&seed_bytes);
+                    StdRng::from_seed(seed_array)
+                } else {
+                    return Err(JsValue::from_str("Seed must be exactly 32 bytes"));
+                }
+            },
+            None => StdRng::from_entropy(),
+        };
         let coin_seed: [u64; 4] = rng.gen();
 
         let rng = RpoRandomCoin::new(coin_seed.map(Felt::new));

crates/web-client/test.html

@@ -123,13 +123,13 @@
         });
       }
 
-      async function createMidenWebClient(dbName = "MidenClientDB") {
+      async function createMidenWebClient(dbName = "MidenClientDB", initSeed) {
         try {
           // let rpc_url = "http://18.203.155.106:57291"
           let rpc_url = "http://localhost:57291";
           let envoy_proxy_url = "http://localhost:8080";
           const webClient = new WebClient();
-          await webClient.create_client(rpc_url);
+          await webClient.create_client(rpc_url, null, initSeed);
           return webClient;
         } catch (error) {
           console.error("Failed to create client with web store:", error);
@@ -421,10 +421,20 @@
 
       // Done
       async function testCreateNewWallet() {
-        console.log("testCreateNewWallet started");
-        let webClient = await createMidenWebClient();
+        const initSeed = new Uint8Array([
+          223, 198, 73, 130, 93, 79, 220, 107, 25, 181, 91, 235, 101, 105, 136,
+          172, 151, 161, 174, 73, 142, 81, 238, 192, 227, 93, 54, 113, 136, 223,
+          75, 174,
+        ]);
 
-        // await createNewWallet(webClient, "Private", true);
+        console.log("testCreateNewWallet started");
+        const webClient = await createMidenWebClient("MidenClientDB", initSeed);
+        const wallet = await webClient.new_wallet(
+          AccountStorageMode.public(),
+          true
+        );
+        console.log("Wallet id: ");
+        console.log(wallet.id().to_string());
 
         console.log("testCreateNewWallet finished");
       }

crates/web-client/test/global.test.d.ts

@@ -77,6 +77,7 @@ declare global {
     TransactionRequestBuilder: typeof TransactionRequestBuilder;
     TransactionScriptInputPair: typeof TransactionScriptInputPair;
     TransactionScriptInputPairArray: typeof TransactionScriptInputPairArray;
+    WebClient: typeof WebClient;
     Word: typeof Word;
     create_client: () => Promise<void>;
 
@@ -87,6 +88,7 @@ declare global {
         maxWaitTime?: number,
         delayInterval?: number
       ) => Promise<void>;
+      refreshClient: (initSeed?: Uint8Array) => Promise<void>;
     };
   }
 }

crates/web-client/test/mocha.global.setup.mjs

@@ -133,6 +133,7 @@ before(async () => {
       window.TransactionRequestBuilder = TransactionRequestBuilder;
       window.TransactionScriptInputPair = TransactionScriptInputPair;
       window.TransactionScriptInputPairArray = TransactionScriptInputPairArray;
+      window.WebClient = WebClient;
       window.Word = Word;
 
       // Create a namespace for helper functions
@@ -166,6 +167,12 @@ before(async () => {
           timeWaited += delayInterval;
         }
       };
+
+      window.helpers.refreshClient = async (initSeed) => {
+        const client = new WebClient();
+        await client.create_client(rpc_url, prover_url, initSeed);
+        window.client = client;
+      };
     },
     LOCAL_MIDEN_NODE_PORT,
     env.REMOTE_PROVER ? REMOTE_TX_PROVER_PORT : null

crates/web-client/test/new_account.test.ts

@@ -25,15 +25,30 @@ interface NewAccountTestResult {
 
 export const createNewWallet = async (
   storageMode: StorageMode,
-  mutable: boolean
+  mutable: boolean,
+  clientSeed?: Uint8Array,
+  isolatedClient?: boolean
 ): Promise<NewAccountTestResult> => {
+  // Serialize initSeed for Puppeteer
+  const serializedClientSeed = clientSeed ? Array.from(clientSeed) : null;
+
   return await testingPage.evaluate(
-    async (_storageMode, _mutable) => {
-      const client = window.client;
+    async (_storageMode, _mutable, _serializedClientSeed, _isolatedClient) => {
+      if (_isolatedClient) {
+        // Reconstruct Uint8Array inside the browser context
+        const _clientSeed = _serializedClientSeed
+          ? new Uint8Array(_serializedClientSeed)
+          : undefined;
+
+        await window.helpers.refreshClient(_clientSeed);
+      }
+
+      let client = window.client;
       const accountStorageMode =
         _storageMode === "private"
           ? window.AccountStorageMode.private()
           : window.AccountStorageMode.public();
+
       const newWallet = await client.new_wallet(accountStorageMode, _mutable);
 
       return {
@@ -50,7 +65,9 @@ export const createNewWallet = async (
       };
     },
     storageMode,
-    mutable
+    mutable,
+    serializedClientSeed,
+    isolatedClient
   );
 };
 
@@ -110,6 +127,19 @@ describe("new_wallet tests", () => {
       expect(result.is_new).to.equal(true);
     });
   });
+
+  it("Constructs the same account when given the same init seed", async () => {
+    const clientSeed = new Uint8Array(32);
+    crypto.getRandomValues(clientSeed);
+
+    // Isolate the client instance both times to ensure the outcome is deterministic
+    await createNewWallet(StorageMode.PUBLIC, false, clientSeed, true);
+
+    // This should fail, as the wallet is already tracked within the same browser context
+    await expect(
+      createNewWallet(StorageMode.PUBLIC, false, clientSeed, true)
+    ).to.be.rejectedWith(/Failed to insert new wallet: AccountAlreadyTracked/);
+  });
 });
 
 // new_faucet tests

package.json

@@ -1,6 +1,6 @@
 {
   "dependencies": {
-    "prettier": "^3.3.3"
+    "prettier": "^3.4.2"
   },
   "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
 }