Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: replace Bancor integration with Uniswap network integration #382

Merged
merged 2 commits into from
May 27, 2024
Merged

Feature: replace Bancor integration with Uniswap network integration #382

merged 2 commits into from
May 27, 2024

Conversation

YarikRevich
Copy link
Collaborator

No description provided.

@YarikRevich YarikRevich self-assigned this May 25, 2024
@YarikRevich YarikRevich added the enhancement New feature or request label May 25, 2024
@YarikRevich YarikRevich linked an issue May 25, 2024 that may be closed by this pull request
Feature: replace Bancor integration with Uniswap network integration #381
Open
peterlimg
peterlimg approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YarikRevich
Copy link
Collaborator Author

Affected tests are passed: https://github.com/0chain/zwalletcli/actions/runs/9237592449/job/25431247124?pr=382

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped true
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli feature/bancor-to-uniswap
0chain
blobber
authorizer
0box
0dns

@YarikRevich YarikRevich merged commit e90f344 into sprint-1.15 May 27, 2024
7 of 9 checks passed
@YarikRevich YarikRevich deleted the feature/bancor-to-uniswap branch May 27, 2024 10:03
@dabasov dabasov mentioned this pull request May 30, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

Assignees

@YarikRevich YarikRevich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: replace Bancor integration with Uniswap network integration
3 participants
@YarikRevich @service-0chain @peterlimg