Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make size optional #1390

Merged
merged 14 commits into from
Mar 26, 2024
Merged

Make size optional #1390

merged 14 commits into from
Mar 26, 2024

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Feb 23, 2024 •
edited
Loading

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.83721% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 15.02%. Comparing base (c2bd391) to head (786760e).

Files Patch % Lines
...ode/go/0chain.net/blobbercore/filestore/storage.go 47.61% 17 Missing and 5 partials ⚠️
...et/blobbercore/handler/object_operation_handler.go 47.05% 9 Missing ⚠️
...de/go/0chain.net/blobbercore/challenge/protocol.go 0.00% 6 Missing ⚠️
...ain.net/blobbercore/handler/file_command_upload.go 0.00% 3 Missing ⚠️
...go/0chain.net/blobbercore/allocation/connection.go 0.00% 2 Missing ⚠️
...ain.net/blobbercore/handler/file_command_update.go 0.00% 1 Missing ⚠️
.../go/0chain.net/blobbercore/reference/objectpath.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@               Coverage Diff               @@
##           sprint-1.13    #1390      +/-   ##
===============================================
+ Coverage        15.01%   15.02%   +0.01%     
===============================================
  Files              178      178              
  Lines            19906    19922      +16     
===============================================
+ Hits              2989     2994       +5     
- Misses           16546    16556      +10     
- Partials           371      372       +1
Flag Coverage Δ
Unit-Tests 15.02% <48.83%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hitenjain14 Hitenjain14 mentioned this pull request Mar 6, 2024
Merged
3 tasks
@Hitenjain14 Hitenjain14 linked an issue Mar 6, 2024 that may be closed by this pull request
Stream Upload #1395
Open
@Hitenjain14 Hitenjain14 marked this pull request as ready for review March 14, 2024 21:11
dabasov
dabasov approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov changed the base branch from sprint-1.13 to sprint-1.14 March 26, 2024 20:42
@dabasov dabasov merged commit 9f2ac26 into sprint-1.14 Mar 26, 2024
7 checks passed
@dabasov dabasov deleted the feat/optional-size branch March 26, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream Upload
3 participants
@Hitenjain14 @codecov-commenter @dabasov